Skip to content

Add version constraints to junit-platform-launcher added in plug-in launch #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iloveeclipse merged 1 commit into from
Nov 12, 2025
Merged

Add version constraints to junit-platform-launcher added in plug-in launch #2068

iloveeclipse merged 1 commit into from
Nov 12, 2025

Conversation

@trancexpress
Copy link
Contributor

@trancexpress trancexpress commented Oct 27, 2025 •
edited
Loading

See eclipse-jdt/eclipse.jdt.ui#2572 and eclipse-jdt/eclipse.jdt.ui#2574. Similar to what we have in JDT, we add a version range to junit-platform-launcher added in JUnitPluginLaunchConfigurationDelegate.

@trancexpress
Copy link
Contributor Author

trancexpress commented Oct 27, 2025

Note that this PR requires changes in JDT UI that were done today, we should wait some time before trying to merge it.

@trancexpress trancexpress mentioned this pull request Oct 27, 2025
Merged
@github-actions
Copy link

github-actions bot commented Oct 27, 2025 •
edited
Loading

Test Results

  623 files  ±0    623 suites  ±0   50m 44s ⏱️ -23s
3 648 tests ±0  3 593 ✅ ±0   54 💤 ±0  1 ❌ ±0 
8 213 runs  ±0  8 073 ✅ ±0  139 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 497875a. ± Comparison against base commit 08a144c.

♻️ This comment has been updated with latest results.

@iloveeclipse
Copy link
Member

iloveeclipse commented Oct 28, 2025

Jenkins build failed with OOM again (eclipse-platform/eclipse.platform.releng.aggregator#3436)

19:46:32  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-source-plugin:5.0.1-SNAPSHOT:plugin-source (plugin-source) on project org.eclipse.pde.ui: Error creating source archive: Problem creating jar: Execution exception: Java heap space -> [Help 1]

@laeubi
Copy link
Contributor

laeubi commented Oct 28, 2025

Jenkins build failed with OOM again (eclipse-platform/eclipse.platform.releng.aggregator#3436)

19:46:32  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-source-plugin:5.0.1-SNAPSHOT:plugin-source (plugin-source) on project org.eclipse.pde.ui: Error creating source archive: Problem creating jar: Execution exception: Java heap space -> [Help 1]

Well it seems cheaper to use developers "resources" and rerun builds over and over again than to plug in some RAM into a virtual maschine :-\

As of today Github offers already Linux with 4 cores @ 16 GB by default while Jenkis is still creeping with 2 cores and 4GB ...

@merks
Copy link
Contributor

merks commented Oct 28, 2025

I have asked:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4759

I think most project don't actually need the more resource so it could be wasteful to make that the default, but I have yet to figure out how to allocate a bigger instance...

@HannesWell HannesWell force-pushed the jdtui_gh2572 branch 2 times, most recently from bbfb04c to d78151f Compare October 30, 2025 23:33
HannesWell
HannesWell approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
The build should also succeed now.

@trancexpress
Copy link
Contributor Author

trancexpress commented Nov 12, 2025

Seems like I forgot about this PR. Lets merge it this week, it shouldn't do harm.

@trancexpress
Copy link
Contributor Author

trancexpress commented Nov 12, 2025

Fail in the Linux build is:

org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.testGetMergedBundleMap_automaticAddedWorkspacePlugins_multiVersionPluginDisabledWithSpecificVersion -- Time elapsed: 0.348 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 

expected: 
  {
  plugin.a-1.0.0(w)="default:default",
  plugin.a-3.0.0(w)="default:default"
  }
 but was: 
  {
  org.eclipse.core.contenttype-3.9.800.v20251105-1620(e)="default:default",
  org.eclipse.core.jobs-3.15.700.v20250725-1147(e)="default:default",
  org.eclipse.equinox.app-1.7.500.v20250629-0337(e)="default:default",
  org.eclipse.equinox.common-3.20.300.v20251111-0312(e)="2:true",
  org.eclipse.equinox.preferences-3.12.100.v20251111-0704(e)="default:default",
  org.eclipse.equinox.registry-3.12.600.v20250906-0651(e)="default:default",
  plugin.a-1.0.0(w)="default:default",
  plugin.a-3.0.0(w)="default:default"
  }
	at org.eclipse.pde.ui.tests.launcher.AbstractLaunchTest.assertPluginMapsEquals(AbstractLaunchTest.java:138)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1095)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1080)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1070)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.testGetMergedBundleMap_automaticAddedWorkspacePlugins_multiVersionPluginDisabledWithSpecificVersion(PluginBasedLaunchTest.java:459)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)

@trancexpress
Copy link
Contributor Author

trancexpress commented Nov 12, 2025

@iloveeclipse can we merge this? Its a left-over I forgot about.

@iloveeclipse iloveeclipse merged commit 7e6153c into eclipse-pde:master Nov 12, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iloveeclipse iloveeclipse iloveeclipse approved these changes

@HannesWell HannesWell HannesWell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trancexpress @iloveeclipse @laeubi @merks @HannesWell